Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TitleBarButton: Fix Foreground not using property value at initial #1017

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

seasonyuu
Copy link
Contributor

@seasonyuu seasonyuu commented Mar 26, 2024

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

image

Cause using RenderButtonsForeground as Canvas's FillColor, when app initial the window theme, ButtonsForeground changed but the event hadn't raised.

Issue Number: #1009 (comment)

What is the new behavior?

image

  • Set RenderButtonsForeground as ButtonsForeground when TitleBarButton Loaded.

Other information

@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request dotnet labels Mar 26, 2024
@pomianowski pomianowski self-assigned this Mar 26, 2024
@pomianowski pomianowski merged commit ccc2e44 into lepoco:development Mar 26, 2024
2 checks passed
@DDarknessOne
Copy link

The problem is still present here.
Version: 3.0.3
OS: Windows 11 23H2

@seasonyuu
Copy link
Contributor Author

The problem is still present here. Version: 3.0.3 OS: Windows 11 23H2

I had tried many times. Please show what you do.

@Abomariam1
Copy link

please write an example , the issue does not solved.

@DDarknessOne
Copy link

image

This it the unmodified WPF UI Gallery. The same thing happens when i create a blank net8.0 project with wpfui.

@seasonyuu
Copy link
Contributor Author

I just run it from development branch without any change, it works like a charm.
image
@Abomariam1 @DDarknessOne , maybe you should clear build output dir and retry.

@seasonyuu
Copy link
Contributor Author

PS, git log information.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet PR Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants