use std::vector inside lcArray class #849
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the custom dynamic allocation logic for
lcArray
withstd::vector
. The standard library vector grows by some factor when resizing to make the insertion cost average out to be roughly constant. The old implementation forlcArray
appeared to be resizing every N elements for some user configurable N. When loading a large model with roughly 58000 pieces,Project::load
takes about 3000ms on my machine for the oldlcArray
and 2800ms for the new implementation withstd::vector
when profiling in Visual Studio. Application memory usage in task manager seems to be identical for both versions. RemovinglcArray
entirely is more involved, so I preserved most of the existing API.