Features/dependencies on files on pyton path #903
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies mostly). Fixes lektor#865
…accept pathlib objects.
typo Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Suggested help string Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
…n function more readable.
…equirements_file) as it is not used / needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Fixes #499 - or at least makes it much more manageable.
Description of Changes
None of this has happened yet, because this is a draft pull request to spark discussion.
I have relaxed the requirement for the path cache that every file be below the
env.root_pathbut can also be below any of the paths insys.path. This allows source files in plugins to work, even if the plugin is not a source install, but instead a normal dependency.What do you think? I am kind of surprised that this worked at all. Also I have no ideas about the ramifications.
So - what do you guys think, what would be a better way to support source files that are not below
env.root_pathand what ramifications does a change like this have?One thing I don't like about this, is that before this AFAIK no absolute paths where stored in the build-state, making the entire project eminently relocatable (even between machines). Not sure if that is actually a design goal though.