Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import docs #787

Open
wants to merge 438 commits into
base: master
Choose a base branch
from
Open

Import docs #787

wants to merge 438 commits into from

Conversation

xlotlu
Copy link
Contributor

@xlotlu xlotlu commented Jun 13, 2020

This merges the docs from lektor-website as a stand-alone site, along with the needed models, templates etc.

Closes #756
Blocks lektor/lektor-website#226

The script generating this branch is available at https://gist.github.com/xlotlu/1dd9076e4886faa77797f1b3720f20a3. It uses https://github.com/newren/git-filter-repo/.

nomorepanic and others added 30 commits April 2, 2016 19:14
typo fix in flow block models documentation
Add 'Taiga.io Support' to Showcase
Now that Lektor supports Python 3, we need to document this support.
This change is perhaps a bit extreme: it replaces all explicit
references to Python 2.7 with explicit references to Python 3.5.
However, it's a good start, and it can and should be reviewed before
being merged.
added code to install python dependencies for Ubuntu
Add lektor-creative-commons plugin to plugin list
So that mistune can parse it correctly. Fixes lektor-website/106
…art-video-iframe

Add quotations marks around HTML attribute
Because valid HTML is better than invalid HTML
@xlotlu
Copy link
Contributor Author

xlotlu commented Jun 13, 2020

Guys, please help with a checklist for getting things done? Please also commit to this branch liberally and help with related issues?

First thing that comes to mind is lektor/lektor-website#219.

@xlotlu xlotlu force-pushed the import-docs branch 2 times, most recently from 500bbaa to a98bcee Compare June 14, 2020 14:31
@xlotlu
Copy link
Contributor Author

xlotlu commented Jun 14, 2020

Unfortunately I never thought about the original #PR / #issue references in the imported commits, which polluted lots of local issues with wrong references. See for example #304 (yey for another spurious reference).

Force-pushing only made things worse, as the commits are preserved in the reflog and github doesn't remove the links.

@dwt
Copy link

dwt commented Feb 9, 2021

You could probably rework the script that imports the old repo to regex replace all #$bug_id references with absolute links to the original repo.

But to be fair: If it was just for me, I would be ok with just importing the current status without transporting all the history. It would be nice to get the history, but going forward it will probably not be super neccessary.

@xlotlu
Copy link
Contributor Author

xlotlu commented Feb 9, 2021

You could probably rework the script that imports the old repo to regex replace all #$bug_id references with absolute links to the original repo.

@dwt this is already there, it's just that I decided to use the <project-name>/#<thing-id> form instead of the full url:
https://gist.github.com/xlotlu/1dd9076e4886faa77797f1b3720f20a3#file-import-docs-sh-L36

But to be fair: If it was just for me, I would be ok with just importing the current status without transporting all the history. It would be nice to get the history, but going forward it will probably not be super neccessary.

Well, it's true that from a practical standpoint the commit history is not as relevant as code history, more so due to them not being in sync, but... It's history.

Even if it would be entirely irrelevant (which it isn't, diffs are useful information, for docs too), I personally think the commit history should be preserved because it snapshots people's contributions. It's a good homage to their efforts to preserve this info.

@dwt
Copy link

dwt commented Feb 11, 2021

@xlotlu More power to you - as long as it doesn't prevent getting this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving lektor-website into this repository