Added a 'Save and Preview' button and made the 'Save' button fire an alert when successful and reload the page so changes are reflected. #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from Lektor Master
…to Save and Preview (existing functionality of Save button) per issue #92
…to window.alert to eliminate error in git hook
runfalk
requested changes
Oct 21, 2019
|
Thank you for your contribution! I've added some comments to your PR. |
…he dialog. Adjusted the SlideDialog component to refresh the page on close by escape or by clicking close text (this may not be desired - unsure)
|
@hannylicious thanks or working on this. Could you add a screenshot of how it looks on the description of this issue? Since it is a UI change, it helps to see the actual image of how it looks. |
|
This is a gif showing the new buttons in action and the page refresh on successDialog close. Don't mind the index.html template not showing up. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
#92
Fixes #
Related Issues / Links
Description of Changes
https://user-images.githubusercontent.com/3648225/67443853-3605e400-f5cc-11e9-8ae3-422934e2af32.gif
Per the recommendation in issue #92 I added a secondary button. The 'Save Changes' button now alerts the user on successful changes and the 'Save and Preview' button saves the changes and then takes the user to the preview (same as before)