Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.7 #1173

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Drop support for python 3.7 #1173

merged 6 commits into from
Nov 2, 2023

Conversation

dairiki
Copy link
Contributor

@dairiki dairiki commented Oct 31, 2023

Python 3.7 was EOLed on June 27, 2023.

This PR removes testing under python 3.7. It also includes some code cleanups that can be made if we no longer wish to support running under python 3.7.

Description of Changes

  • Link to corresponding documentation pull request for getlektor.com

Copy link
Contributor

@yagebu yagebu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@dairiki dairiki marked this pull request as draft November 2, 2023 18:45
@dairiki
Copy link
Contributor Author

dairiki commented Nov 2, 2023

On second thought, I think I want to split the pyupgrade bits into a separate PR. (Especially since they mangle so much code.)

Hold off on merging...

Pillow 6.2.x is the first release for which PyPI contains wheels for
python 3.8.
For plugins that might use them, provide
`lektor.compat.TemporaryDirectory` and `lektor.compat.importlib_metadata`
(along with a DeprecationWarning).
@dairiki
Copy link
Contributor Author

dairiki commented Nov 2, 2023

I've now removed the pyupgrade-induced changes from this PR. (I will create a new PR with those in a bit.)

@dairiki dairiki marked this pull request as ready for review November 2, 2023 19:59
@dairiki dairiki merged commit 2ca065c into lektor:master Nov 2, 2023
15 checks passed
@dairiki dairiki deleted the feat.drop-py37 branch November 2, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants