Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lektor.builder: note source metadata early; other cleanups #1148

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Refactor lektor.builder: note source metadata early; other cleanups #1148

wants to merge 5 commits into from

Commits on Jun 5, 2023

  1. tests: enable mypy checks on lektor.builder

    @dairiki
    dairiki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    c7fb1d8 View commit details
    Browse the repository at this point in the history

  2. refactor: capture FileInfo state early 

    In order to minimize the possibility of race conditions, the idea here
is to capture source state (mtime, size, and possibly checksum) as
early as possible in the build process.  This allows us to detect
(and rebuild during the next build cycle) the case where a source file
changes during the time that an artifact is being generated.

Previously the computation/caching of those file metadata was deferred
until such time as they were requested. (That deferral did not result
in any saving of computational effort, since, at the end of the build
the metadata is always computed and written into the buildstate
database.)
    @dairiki
    dairiki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    3c2b219 View commit details
    Browse the repository at this point in the history

  3. refactor(builder): refactor db connection handling

    @dairiki
    dairiki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4cb7749 View commit details
    Browse the repository at this point in the history

  4. refactor(builder): keep db connections open for life of builder

    @dairiki
    dairiki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    cf24cec View commit details
    Browse the repository at this point in the history

  5. refactor(builder): WIP notes/comments

    @dairiki
    dairiki committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    8b04a45 View commit details
    Browse the repository at this point in the history