New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go/no-go tests to check that various sites are buildable #1010
base: master
Are you sure you want to change the base?
Conversation
Great, thanks for this. Do you want to incorporate the runslow tests into the github action for publishing, as a final test, but still an automatic one? |
That's an interesting option, though, if the test is going to fail, it would be nice to find out about it before then. I suppose we could always --runslow the CI tests. I disabled the test by default mostly for the benefit of developers (i.e. me) who are running the tests interactively, where including that one --runslow test triples the running time of |
9e0f45a
to
f3e6fc1
Compare
I agree, and that marginal increase in the test time of the normal CI runs seems fine to me. |
f40e52b
to
e9f6d54
Compare
On the GitHub runners, the lektor-website --runslow test seems to add 2 to 3 minutes to the run time. I also noticed that |
Currently, these tests build the sites included in the Lektor source — example, tests/demo-site, tests/dependency-test-project, tests/child-sources-test-project — as well as the master branch of lektor-website. The lektor-website test is skipped by default. Use the `--runslow` custom pytest parameter to enable it.
The lektor-website/packages/project-data plugin requires `readme_renderer[md]`, which, in turn requires `cmarkgfm<0.7.0`. There is no wheel appropriate for the Windows GitHub runner for `cmarkgfm==0.6.0`, so when Lektor goes to install the plugin, the extension must be compiled. Apparently the `ProgramData` and `ProgramFiles` environment variables are important to this process.
Installing ffmpeg takes about 20-30 seconds. Testing the ffmpeg functionality on one version of python seem sufficient.
750eefb
to
5af8f76
Compare
This adds a set of tests that check that all the sample sites included the Lektor source code build without error.
The sites built include the
example
site as well as the various test projects in thetests
subdirectory.A test is included which builds the master branch of lektor-website. However, since it is very slow and requires internet connectivity, this test is skipped by default. A new
--runslow
custom pytest command-line parameter has been implemented which will enable this test.