chore: remove infolabels from settings

[SethFalco]

Before when opening the context menu on the settings, it would show "Mark as watched".

I'm not sure why infoLabels were applied to these non-video menu items, but I don't think they need to be there, do they?

This change stops Kodi from offering to mark Settings as watched.

Screenshots

Before

After

[lekma]

is there any other way to set the plot on an item? (the text that says "No information available" on your second screenshot)

[SethFalco]

Ahh! Good catch, I didn't notice that tbh.
I'm not aware of how to include text in another way.

I can't find anything in the docs, and I tried a few hacks, like populating it with game infoLabels instead, but to no avail. 🤔

Looking at other extensions, seems they just leave the sidebar with "No information available" as well.

I'll investigate this further tonight, I'd prefer to keep the label too.

If we do have to decide between either:

1. Lose the label, and remove the "Mark as watched"
2. Keep the label, but Settings has "Mark as watched" (which doesn't break anything!)

I'd personally prefer the first option, but I'll leave it up to you.
Motivation being that scenario one is fine imo, but scenario two is unexpected behavior.

[lekma]

it is a bug with kodi (imo), items marked as not playable should not have this context menu entry visible...

[SethFalco]

I'm partial to that assessment. I was thinking the same at first, but thought I could rationalize it.

The infoLabels indicates that it's a video, so I think it's fair to treat it like any other video.

Having IsPlayable === False doesn't mean it's not a playable item at all, but rather that it's not available to play now. Maybe permissions, network conditions, scheduled videos, etc. They are still videos, but just not playable videos.

And one can "Mark as watched" because they have indeed seen it before, perhaps on another device/account where they did have access to it.

[SethFalco]

Reading the docs on the IsPlayable property, it looks like it could be specific to PVR though too. 🤔
I don't see any other reference to it.

https://xbmc.github.io/docs.kodi.tv/master/kodi-base/d6/d4d/class_p_v_r_1_1_c_p_v_r_epg_info_tag.html#ad54b1dbf2db7232e1d3dce9d8570db78

Which is its own info label type:
https://kodi.wiki/view/InfoLabels#PVR

[lekma]

The infoLabels indicates that it's a video, so I think it's fair to treat it like any other video.

true, but I couldn't find any other way to customize the "plot" (and I'm not the only one, see YouTube add-on, ...) , ideally list items should have a "description" property regardless of what they are (video, music, ...), because even using the video info labels is not always useful when using a customized skin.

Being playable doesn't mean it's not a playable item at all, but rather that it's not available to play now. Maybe permissions, network conditions, scheduled videos, etc. They are still videos, but just not playable videos.

well, here's my mistake 😄

[SethFalco]

I've spent probably too much time on this, and I'm fairly sure we're not going to get anywhere with the default skin (Estuary), atm.

I think the best thing would be to decide from the two options above (you know my preference) and see if this can be addressed in the skin later.

I'm reviewing the Estuary code atm, pretty sure the issue is this line:

• https://github.com/xbmc/xbmc/blob/master/addons/skin.estuary/xml/View_50_List.xml#L322

If the skin were updated to do one of the following, we could achieve what we wanted:

• Display ListItem.Label2 if a more specific type isn't available, and add that to menu items.
• Display Game.Overview for games. It's a hack, but games don't add context menu items.

Meanwhile, I'd consider this an issue with the default skin. 🤔
I really see no conventional way to specify text for non-media menu items.

[lekma]

just for reference: ListItem.setProperty()

IsPlayable | string - "true", "false" - Mark the item as playable, mandatory for playable items