Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using move_to_top when windows take focus #1211

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

barkyq
Copy link
Contributor

@barkyq barkyq commented Jan 8, 2024

Description

using move_to_top when windows take focus

Fixes #1206

Type of change

  • Development change (no change visible to user)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation only update (no change to the factual codebase)
  • This change requires a documentation update

Checklist:

  • Ran make test locally with no errors or warnings reported
    Note: To fully reproduce CI checks, you will need to run make test-full-nix. Usually, this is not necessary.
  • Manual page has been updated accordingly
  • Wiki pages have been updated accordingly (to perform after merge)

Copy link
Contributor

@Eskaan Eskaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving a window on top here is only temporary as it's still in a different place in the focus managers window stack and will be sorted up front as soon as sort_windows is called again (for example when a new window is opened).

@barkyq barkyq marked this pull request as draft January 11, 2024 20:03
@barkyq
Copy link
Contributor Author

barkyq commented Jan 11, 2024

changed to draft PR, need to figure out bugs with focus changing when switching tags etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

floating vs floating should restack when moving focus.
2 participants