-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor file handling #1050
base: main
Are you sure you want to change the base?
Refactor file handling #1050
Conversation
Getting the return type of |
Thanks to the awesome support of Eskaan, this is review ready I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test, just glanced over the changes and they look good to me
Just noticed I broke |
Going back to draft, as I noticed now that I fixed the migration, fallback to toml works no more. I mean, we could go this route and don't load |
Depends on how long ago the switch to ron was released? If it's fair to assume that most people have migrated, I think going that route is fine as long as we communicate it clearly in the release notes and our announcement channel. We don't have to keep technical debt around for too long, given that we are still in a kind of "beta" state with the project anyway. |
Description
So far this is just a refactor to get started with cleaning up file handling.
I am still considering if pulling all the
path
handling into a similar module inleftwm-core
, or if this would be kind of redundant, as manyPath
andPathBuf
references are tied directly to the respective lib anyways.Type of change
Updated user documentation:
Please insert user documentation that should be updated (as in the wiki).
See CONTRIBUTING.md User Documentation section for further details.
Note: Manual page changes must be performed in a commit, not in this PR section.
Checklist:
make test-full
locally with no errors or warnings reportedNote: To fully reproduce CI checks, you will need to run
make test-full-nix
. Usually, this is not neccesary.