Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display info message if app is not deployed #120

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pradel
Copy link
Contributor

@pradel pradel commented Sep 12, 2020

Currently blocked by dokku/dokku#4134

@pradel pradel added the blocked label Oct 4, 2020
@pradel
Copy link
Contributor Author

pradel commented Dec 2, 2020

We can now continue with this one dokku/dokku#4134 (comment).
The best would be:

  • when we sync, check if the app is deployed
  • save it in the db as a boolean flag
  • on the page along with the message add a button to update the app status

@pradel pradel removed the blocked label Dec 2, 2020
@josegonzalez
Copy link

This should be unblocked. Also, exit codes are now slightly different (or should be) if an app does not exist. See https://dokku.github.io/release/dokku-0.24.0 for details, but basically if you get an exit code of 20, that means the app does not exist. Might save on ssh commands :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants