Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport to v0.16.x] Change source.url in rockspec to use git+https:// instead of git:// protocol (deprecated by GitHub) #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

milesrichardson
Copy link

@milesrichardson milesrichardson commented Mar 21, 2022

This PR is a backport of #270 to the v0.16.x "branch" (there is only a tag AFAICT). I created a new branch from the v0.16.1 tag. I tried to make the GitHub PR target this tag, but apparently you can't target tags, and there is no corresponding branch that I could find to target. So at the moment this PR targets the master branch (meaning you probably don't want to merge it directly).

Quoting from #270:

GitHub deprecated usage of git:// (unencrypted Git protocol) on March 15th, 2022, so LuaRocks will fail to install any package including a source.url starting with git://. According to the LuaRocks documentation, the correct syntax for referencing https:// URLs is git+https://.

GitHub deprecated usage of `git://` (unencrypted Git protocol)
on March 15th, 2022.

This commit backports the change to `v16.x`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant