Fix Balance Sheet & Income Tax comparisons report by dates or by periods #8169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylavoie
changed the title
ehuelsmann
reviewed
Apr 21, 2024
| column_path_prefix => [ 0 ]); | ||
| #die np $rpt; |
There was a problem hiding this comment.
could you remove this stray comment?
|
I'm afraid that fixing the comparisons broke the date intervals... |
|
@ylavoie how about approaching this differently: how about removing the complexity of needing to resolve this all server-side? How about making a bit of JS which calculates the correct start and end dates and sets the from and to dates accordingly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore Balance Sheet & Income Tax Comparison reports when selection is done by dates or by periods