Unified packet capture interface, take 2 #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parroting JD:
The pragma pack compiler directive affects all structures following
the pragma. So, an innocent struct in a header file which wants
to be packed can mess up other code in fun ways, depending on orders of
header includes.
For some reason, IB Verbs configuration seems to be easily broken by
this kind of thing.
Use struct __attribute__((packed)) {...} instead
I'm not smart enough to make the python bindings get generated when the header entries are wrapped in #if's
Blindly copied from the now-deprecated implementation in ib_verbs.cpp
… decimation value.
TODO: Is there a more sensible (less-transposey) data ordering. [Probably]
This is actually quite annoying. The call to blank a source doesn't know about the details of the packet structure, and one can't necessarily blank the right parts of the receive buffer when only given nsrc, src, nchan, chan, since these values have been abused. E.g. the output buffer is in Time x Chan x Antpol order, but the Chan dimension can be a multiple of nchan, and nsrc != the number of Antpols in the system. Hack the information out of the packet stream and then write a clurgy blanking function. Barely tested.
This reverts commit b107bfc. Don't do this for now to make things faster
… into jaycedowell-ibverb-support
…bifrost into add-simple-packet
Add simple packet
Packet formats from the LWA352 OVRO bifrost branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a unified packet capture interface that makes it easier to add new packet formats to Bifrost and to read packet formats from the network (unicast or multicast) or from disk. This also includes a generalization of the packet writer interface. This PR changes the Bifrost API in a couple of ways:
bifrost.udp_capture.UDPCapture is now bifrost.packet_capture.UDPCapture
there is a new PacketCaptureCallback class that wraps the callbacks
bifrost.udp_transmit is now bifrost.packet_writer
This should also address the segfault I was running into in #137.