Sort repeatables scripts with dependencies #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… repeatable-deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables by default a new but it is possible to specify dependencies for each repeatable script file.
A slight refactor to the parsing of evolve file options has been necessary to permit options on several lines :
-- evolve-tx-off
-- evolve-repeatable-deps=XXX
Legacy behaviour is still supported :
-- evolve-tx-off evolve-repeatable-deps=XXX
The "evolve-repeatable-deps" option must be declared with an equal sign then the file dependencies, separated by pipes :
-- evolve-repeatable-deps=PROC_A|PROC_B|PROC_C
Spaces can be used to add spacing :
-- evolve-repeatable-deps = PROC_A | PROC_B | PROC_C
Dependencies are repeatable script descriptions with underscores (_) instead of spaces.
This modification has been made to make RetryRepeatableMigrationsUntilNoErrorNew obsolete : if dependencies are correctly managed, script order should always be right.
Circular dependencies will make the migration fail before migrating the repeatables.