Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate python-kms to 2.0.0 #4019

Merged
merged 3 commits into from May 10, 2023

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Apr 11, 2023

Summary

This Pr intends to make the required changes to upgrade the python-kms library to its newest major release 2.0.0.
fixes #3885

Description of the change(s) you made

  • Migrated and made changes according to this guide.
  • Added some changes that were not mentioned in the guide like this.
  • Added crc32c checksum mechanism according to standards and snippets given here.

Are there any risky areas that deserve extra testing?

There maybe some changes that I have missed, but I tried my best to catch most of them! If there are some changes missed I will be happy to debug them and make the required changes.

Comments

Additionally added the crcmod package for checksum mechanism as described here.

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use zlib for the crc32 checksum instead of adding a new dependency? Like this

key2 = zlib.crc32(signature.encode('utf-8'))

@bjester
Copy link
Member

bjester commented Apr 25, 2023

Could you use zlib for the crc32 checksum instead of adding a new dependency? Like this

key2 = zlib.crc32(signature.encode('utf-8'))

Ah this is crc32c not crc32, which I guess isn't builtin with zlib

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One dependency change by me, but approving so we can test it in CD

@bjester bjester merged commit 7af004e into learningequality:unstable May 10, 2023
9 checks passed
@bjester
Copy link
Member

bjester commented May 10, 2023

CD completed successfully and the unstable server is still functioning appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Google Cloud KMS to latest version
2 participants