Logic for design matrix creation #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pqz317
commented
Apr 5, 2023
•
pqz317
commented
- add design matrix logic in data_utils.py
- example for how to create matrix in create_design_matrix.ipynb
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
eywalker
requested changes
Apr 6, 2023
eywalker
requested changes
Apr 6, 2023
wcst_encode/data_utils.py
Outdated
| pattern = row[f"Item{item_chosen}Pattern"] | ||
|
|
||
| chosen_time = row["FeedbackOnset"] - 800 | ||
| chosen_bin = int(chosen_time / bin_size) |
There was a problem hiding this comment.
generally best to be explicit with things like np.ceil and np.floor (here it is np.floor)
There was a problem hiding this comment.
changed, here and elsewhere though, I often to need to cast as well, so it will be int(np.floor(chosen_time / bin_size)) as long as that doesn't feel redundant
eywalker
requested changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.