feat: apply dupNamespace linter to instances #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgdorais
added
the
awaiting-review
|
How does this interact with |
|
I don't know, but I have no reason to suspect those would introduce duplicate namespaces. If there's a way to exclude those, that's fine by me, of course. |
|
How about adding some tests? |
|
The test doesn't seem to include a result from the linter? Can you use |
semorrison
added
awaiting-author
leanprover-community-mathlib4-bot
added
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caught 14 bugs with no false positives over in leanprover-community/mathlib4#10899