Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upstream casesm and cases_type tactics #597

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

semorrison
Copy link
Collaborator

No description provided.

@semorrison semorrison added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Feb 7, 2024
@fgdorais
Copy link
Collaborator

This looks really good to me except for the naming convention. I think it *m suffix is not great, I understand such suffixes are somewhat common in Mathlib, but they are obscure for core Lean users and Std shouldn't delve into arcana. I would prefer the self-explanatory *_matching or perhaps *_match to save a few keystrokes.

@digama0
Copy link
Member

digama0 commented Feb 19, 2024

I don't like the name cases_match either because cases already overlaps significantly with the match tactic, and it's not really clear that this means match in a completely different sense: not matching on the value itself as an inductive type, but rather finding patterns in the specified targets.

How do people feel about not using a word at all and instead just using a symbol or other keyword, like cases * as patt in h or similar? I think it would be more (grammatically) productive to use some modifier language like this to describe matching patterns rather than suffixed tactic names.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged. merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants