Serve HTTP cache headers. #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttyniwa
commented
Aug 26, 2019
| @@ -64,6 +64,7 @@ public void schemaConfigTest() { | |||
| // -using default resolver builders | |||
| Assert.assertNotNull(schema.getQueryType().getFieldDefinition("greetingFromBeanSource_wiredAsComponent_byMethodName")); | |||
| Assert.assertNotNull(schema.getQueryType().getFieldDefinition("greetingFromBeanSource_wiredAsComponent_byAnnotation")); | |||
| Assert.assertNotNull(schema.getQueryType().getFieldDefinition("greetingFromBeanSource_wiredAsComponent_byAnnotation_withCacheHint")); | |||
There was a problem hiding this comment.
Unit Test Fails.
I don't know how to solve it.
Please let me know.
ttyniwa
commented
Aug 26, 2019
| @@ -135,6 +138,12 @@ public String getGreeting(){ | |||
| return "Hello world !"; | |||
| } | |||
|
|
|||
| @GraphQLQuery(name = "greetingFromBeanSource_wiredAsComponent_byAnnotation_withCacheHint") | |||
| public String getGreeting2(@GraphQLEnvironment ResolutionEnvironment env){ | |||
There was a problem hiding this comment.
If I remove argument, success to pass schemaConfigTest
|
Thanks a bunch for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kaqqao Thank you for developing a great project! I love this.
I want to use Apollo Http cache headers, so I added implementation.
Since this is the almost first time to commit OSS, please point out whatever you want.
https://www.apollographql.com/docs/apollo-server/features/caching/#serving-http-cache-headers
https://github.com/apollographql/apollo-server/blob/d5015f4ea00cadb2a74b09956344e6f65c084629/packages/apollo-cache-control/src/index.ts#L180