Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace AVCodec * with const AVCodec * to read codec information #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

developer0hye
Copy link
Contributor

@developer0hye developer0hye commented Jun 3, 2022

Thanks for writing the great tutorial!

I found some problem having been following your code.

The return type of avcodec_find_decoder is changed Avcodec* to const AVCodec*.

https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/codec.h#L266

@developer0hye
Copy link
Contributor Author

@leandromoreira

Could you review this PR?

The official example code also uses const*.

https://github.com/FFmpeg/FFmpeg/blob/master/doc/examples/decode_video.c#L86

@leandromoreira
Copy link
Owner

Thanks @developer0hye did you test using the current docker ffmpeg image to see if everything works fine?

@developer0hye
Copy link
Contributor Author

@leandromoreira Sorry, I didn't check it with current docker ffmpeg image. After checking it, I will tell you about it.

@leandromoreira
Copy link
Owner

ffmpeg

Thank you :)

@AndreiCherniaev
Copy link

The return type of avcodec_find_decoder is changed Avcodec* to const AVCodec*.

I have the same commit please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants