Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SESSION_REDIRECT_ON_REGISTER #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

milosPavic
Copy link

SESSION_REDIRECT_ON_REGISTER need to be implemented, so that we can send activation email or to do other jobs.

Description

Related Issue

SESSION_REDIRECT_ON_REGISTER need to be implemented, so that we can send activation email or to do other jobs.
@crosa7
Copy link
Contributor

crosa7 commented Nov 7, 2023

Hey! Thank you for the contribution!
Can you add this configuration default value as well please (default values are in Core class)? And could you also provide a test for this change? Thanks a lot!

@milosPavic
Copy link
Author

milosPavic commented Nov 8, 2023 via email

@crosa7
Copy link
Contributor

crosa7 commented Nov 8, 2023

I add configuration value but for test i need to know how and where to do that need to dig inside.I just edit online things with GitHub i don't have it on my computer :) Milos On Tuesday, November 7, 2023 at 06:43:14 PM GMT+1, André Rosa @.> wrote: Hey! Thank you for the contribution! Can you add this configuration default value as well please? And could you also provide a test for this change? Thanks a lot! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>

All tests are inside the /tests folder, but for this you would need to clone it to your computer yes, and setup a database with a simple users table so that the tests can run against that database

@crosa7
Copy link
Contributor

crosa7 commented Nov 8, 2023

I add configuration value but for test i need to know how and where to do that need to dig inside.I just edit online things with GitHub i don't have it on my computer :) Milos On Tuesday, November 7, 2023 at 06:43:14 PM GMT+1, André Rosa @.> wrote: Hey! Thank you for the contribution! Can you add this configuration default value as well please? And could you also provide a test for this change? Thanks a lot! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>

But to make it easier feel free to just add the missing default configuration to Core.php. When I have some time I can then later add the test. When you add the missing config I will then request a code review from Michael

@milosPavic
Copy link
Author

milosPavic commented Nov 9, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants