Don't use Tab as select key #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Tab as select key has 2 problems : 1/ normal select : enter the select, use arrow to select an option, use TAB to go out the option is selected (this could be discussed but why not) then go back to the field use arrow to go to the selected option and use TAB to go out : the option is deselected. This is obviously not want the user want to do 2/ multiple select : the problem here is that the code assume that the selected option is the highlighted value but in case of multiple it is an array of indexes and then the select() code crash because it assume that only an index is given I think that Enter/Space is enough for selection. Removing Tab from select keys remove these side effect and I feel the behaviour quite confortable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Tab as select key has 2 problems :
1/ normal select : enter the select, use arrow to select an option, use TAB to go out the option is selected (this could be discussed but why not) then go back to the field use arrow to go to the selected option and use TAB to go out : the option is deselected. This is obviously not want the user want to do
2/ multiple select : the problem here is that the code assume that the selected option is the highlighted value but in case of multiple it is an array of indexes and then the select() code crash because it assume that only an index is given
I think that Enter/Space is enough for selection. Removing Tab from select keys remove these side effect and I feel the behaviour quite confortable