New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap configuration handling for Elektra #146
Open
kodebach
wants to merge
76
commits into
lcdproc:master
Choose a base branch
from
ElektraInitiative:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elektra requires C99 so snprintf must be available
multi-line comments otherwise break everything
Elektrify with highlevel API and code-generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the hand-written INI parser for loading configurations with libelektra. The PR was implemented at the request of @haraldg.
Among the many benefits of using Elektra are:
However, this PR is not finished. Only a handful of drivers have been updated (see list below). The documentation hasn't been updated at all. Instead information on how Elektra is used was added in
docs/elektra
. Also, since I do not own the necessary hardware, the updated drivers have not been tested. Testing was mostly done with thecurses
driver.I likely won't have much time to work on this going forward. Therefore, I welcome anyone who wants to help out with this PR. To get started take a look at the documentation in
docs/elektra
(°) and if anything is unclear feel free to ask. We would especially appreciate, if people tested the already updated drivers.(°) Note: you don't actually need to use
master
the latest relase of Elektra should work fine.Updated drivers: