This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
Updated the VSIX to make it Visual Studio 2019 compatible #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… WPF451 project template. Many things were bothering me: ViewModelLocator: - using CommonServiceLocator; .vstemplate: - now points to the up-to-date NuGet versions of CommonServiceLocator and MvvmLightLibs .csproj: - valid ToolsVersion - RunCodeAnalysis is now set to false: CA0507 (https://docs.microsoft.com/en-us/visualstudio/code-quality/fxcop-analyzers-faq?view=vs-2019#i-get-warning-ca0507-even-after-ive-installed-the-fxcop-analyzers-nuget-package) No warnings or code change
Closed
|
any reason why this isn't geting merged? its nearly a year now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many firsts for me:
A good code review will be necessary, lol.
I took the liberty of changing the template of the generated WPF451 project type, to reflect new changes in the CommonServiceLocator namespace, and small changes to make the generated code compile without warning/error.