Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm install #832

Merged
merged 1 commit into from Feb 7, 2020
Merged

Fix npm install #832

merged 1 commit into from Feb 7, 2020

Conversation

michaeltintiuc
Copy link
Contributor

PR Checklist

Fixes #831

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: 831

What is the current behavior?

Cannot create container

What is the new behavior?

Container is created as expected

Other information

npm/cli#681

@tzarebczan
Copy link
Contributor

Thank you for the PR @michaeltintiuc ! Sending some appreciation over on Discord.

@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Feb 4, 2020
@lbry-bot lbry-bot assigned akinwale and unassigned akinwale Feb 7, 2020
@akinwale akinwale merged commit 88dc31e into lbryio:master Feb 7, 2020
@akinwale
Copy link
Contributor

akinwale commented Feb 7, 2020

Looks good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker container fails due to npm error
3 participants