Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum word count to a review #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Camty1
Copy link

@Camty1 Camty1 commented Mar 19, 2020

I set the limit to 200 words, and added comments to show what each part does.

I set the limit to 200 words, and added comments to show what each part does.
@jaismith
Copy link
Member

Hey, thanks for the PR! I've discussed this with the LL team, and we're curious why you think there's a need for capping reviews at 200 words. We've seen reviews on the site to be relatively well regulated on their own, but would be interested to hear your motivation if there's something particular you're trying to prevent.

@jaismith
Copy link
Member

Was this inspired by #15?

@Camty1
Copy link
Author

Camty1 commented Sep 17, 2020

I just saw that it was an issue you guys had highlighted, so that’s why I created the PR. I wanted to contribute to it because it has been really helpful for me, so I saw something I could do and did it. I totally understand if it isn’t added to the site, just thought I would do something! Thanks for running an awesome site!

@Camty1
Copy link
Author

Camty1 commented Sep 17, 2020

It was inspired by #15 yeah

@jaismith
Copy link
Member

That's awesome, thank you! We're working through some site upgrades at the moment and will review this when we are getting our next build together (the existing issues in this repo are a little out-of-date, but this does seem like a good change to make!).

@jaismith jaismith added the on hold this is pending other ongoing work label Sep 18, 2020
@ziruihao
Copy link
Contributor

ziruihao commented Nov 9, 2020

@Camty1 Great work on this and thanks for making the PR! Here's some interesting data on the review word count distributions:

image

Since the main goal of #15 is not to inhibit genuine reviews who type a lot (me included haha), but rather just prevent spammers overloading the system, we are going to increase the word count to 1000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold this is pending other ongoing work question
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants