Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main.go #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update main.go #289

wants to merge 1 commit into from

Conversation

ShivangShandilya
Copy link

Description

This PR fixes #288

Notes for Reviewers

log.Fatal() has been replaced with log.Error()

Signed commits

  • Yes, I signed my commits.

@ShivangShandilya
Update main.go
d88af5f 
Signed-off-by: Shivang Shandilya <101946115+ShivangShandilya@users.noreply.github.com>
@welcome
Copy link

welcome bot commented Apr 11, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@leecalcote leecalcote added the language/go Golang related label Apr 11, 2023
gyohuangxin
gyohuangxin reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@gyohuangxin gyohuangxin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShivangShandilya Thanks for your PR, I left a comment.

cmd/main.go Show resolved Hide resolved
@leecalcote leecalcote requested review from Revolyssup and removed request for leecalcote May 2, 2023 15:41
@Chadha93
Copy link
Member

Thanks, @ShivangShandilya, could you help with the Go lint issue too here?

@ShivangShandilya
Copy link
Author

Thanks, @ShivangShandilya, could you help with the Go lint issue too here?

Can you elaborate on this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chadha93 Chadha93 Chadha93 left review comments

@gyohuangxin gyohuangxin gyohuangxin approved these changes

@Revolyssup Revolyssup Awaiting requested review from Revolyssup

Assignees
No one assigned
Labels
language/go Golang related
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes in main.go
4 participants
@ShivangShandilya @Chadha93 @gyohuangxin @leecalcote