Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid changing the URL of the service worker. #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Avoid changing the URL of the service worker. #18

wants to merge 1 commit into from

Commits on Dec 5, 2018

  1. fix: Avoid changing the URL of the service worker. 

    According to the official documentation[1], it's bad practice to change
the URL of the service worker. Also there's not really a point in having
time stamped URLs for the sw-register.js script. This also allows to
simplify the registration quite a bit, leading to less JavaScript to
parse and execute for the browser.

[1] https://developers.google.com/web/fundamentals/primers/service-workers/lifecycle
    @bmeurer
    bmeurer committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    d0aba11 View commit details
    Browse the repository at this point in the history