-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add rerun on change #3112
base: main
Are you sure you want to change the base?
Feat/add rerun on change #3112
Conversation
I voluntarily break the commits into more succinct ones in order to discuss about implementation easily |
I don't think it makes sense to have these at the same level as the others, especially since they're explicitly not versioned. Instead of I'd propose
You should also not rely on the filesystem returning entries in any defined order. It can differ between platforms and filesystems. For this reason, I'd recommend using the same filename format and applying scripts by version number just like migrations are. |
5efa823
to
544538a
Compare
Do we discuss about the choices and implementations here or in the related issue? About the meaning of "change"I may have poorly explained the process and the underlying logic in the related issue. As I think about it, a change is a modification of an entity. This leads to the question of what is an entity? An entity is a thing that has a unique identifier. In the implementation of As we agree that For the design choice between the file suffix
|
802adba
to
79b33f8
Compare
79b33f8
to
0ec4335
Compare
Hello @abonander, any news about the suggestions? :) The main points are:
|
0ec4335
to
b581309
Compare
b581309
to
87ab468
Compare
fixes #3111