v0.1.0-rc PR #537
v0.1.0-rc PR #537
Conversation
# Conflicts: # internal/master/server/namespace/handlers.go # internal/master/state/state.go
internal/server/config/config.go
Outdated
| @@ -32,10 +32,9 @@ type Config struct { | |||
| Token string `yaml:"token,omitempty"` | |||
| } `yaml:"security,omitempty"` | |||
|
|
|||
| WorkDir string `yaml:"workdir"` | |||
| RootDir string `yaml:"root-dirr"` | |||
There was a problem hiding this comment.
Is second "r" is redundant? root-dirr.
internal/cli/command/daemon/agent.go
Outdated
| if apiTlsCa != "" { | ||
| cfg.API.TLS.FileCert = apiTlsCert | ||
| apiTLSCert := os.Getenv("LB_API_TLS_CERT_FILE") | ||
| if apiTLSCa != "" { |
There was a problem hiding this comment.
Looks like you use incorrect variable. I think apiTLSCert should be instead of apiTLSCa.
internal/cli/command/daemon/agent.go
Outdated
| if apiTlsCa != "" { | ||
| cfg.API.TLS.FileKey = apiTlsKey | ||
| apiTLSKey := os.Getenv("LB_API_TLS_PRIVATE_KEY_FILE") | ||
| if apiTLSCa != "" { |
There was a problem hiding this comment.
Looks like you use incorrect variable. I think apiTLSKey should be instead of apiTLSCa.
internal/cli/command/daemon/agent.go
Outdated
| if manifefstdir != "" { | ||
| cfg.ManifestDir = manifefstdir | ||
| storageDriver := os.Getenv("LB_STORAGE_DRIVER") | ||
| if rootDir != "" { |
There was a problem hiding this comment.
Looks like you use incorrect variable. I think storageDriver should be instead of rootDir.
| @@ -0,0 +1,50 @@ | |||
| # Build manifest | |||
| FROM golang:1.11-alpine3.8 as build | |||
| @@ -0,0 +1,35 @@ | |||
| # Build manifest | |||
| FROM golang:1.11-alpine3.8 | |||
There was a problem hiding this comment.
Also, in another Dockerfile (build/docker/lastbackend/Dockerfile.stg).
| switch u.Scheme { | ||
| case "tcp": | ||
| return "tcp", u.Host, nil | ||
| case "unix": |
There was a problem hiding this comment.
You have a variable for this string. You use it in the line 45 for example.
|
Kudos, SonarCloud Quality Gate passed!
|
Fixes
Description
v.0.1.0-rc release candidate PR.
Contains a lot of changes and improvements.
After switching to go-modules, docker images didn't passed build process.
Version
v0.1.0-rc