[11.x] - Compare lowercased column names in getColumnType

[chady]

I saw issue #51429 and wanted to comment that it is the responsibility of the caller to use lowercased names, but then looking at the implementation, the code already lowercases the column names it reads from the schema, so it should also be comparing them to a lowercased version of the passed in name.

[Jubeki]

How about doing the strtolower outside the loop?

$column = strtolower($column);

[chady]

How about doing the strtolower outside the loop?

$column = strtolower($column);

My first thought was to do this, but I see in the same file:

framework/src/Illuminate/Database/Schema/Builder.php

Line 148 in 44d3c12

if (strtolower($table) === strtolower($value['name'])) {

So I went with the same approach. I don't know how important is the performance impact on this particular method.

Additionally, I think if the lowercase needs to be applied outside the loop, it needs to introduce a new variable so that in case the column is missing, the exception message should contain the original column name and not the lowercased one.