Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of my projects I'm enforcing
declare(strict_types=1);
with a QA rule.That's how I found out that
ServiceProvider::addProviderToBootstrapFile()
replaces the whole file. After adding a provider, the strict type declaration was removed from the file and making my QA fail.This PR improves on this, by only replacing the relevant part of the file (the array part). It does so by using regex. It isn't a perfect solution, but at least everything around the array would stay untouched. Because
bootstrap/providers.php
normally doesn't contain a lot of other code, I think this is fine for most general use-cases.