Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Add target existence validation and forcible creation to storage:link command #51394

Closed
wants to merge 1 commit into from

Conversation

kusab85
Copy link

@kusab85 kusab85 commented May 13, 2024

This PR adds following to the StorageLinkCommand

  • target existence validation
  • ability to create nonexistent target directory with --force option

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@kusab85 kusab85 marked this pull request as ready for review May 13, 2024 11:08
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@kusab85
Copy link
Author

kusab85 commented May 14, 2024

Yes @taylorotwell, this PR fixes the bug which occurs when you try to make storage link to nonexistent target directory.
Laravel informs you that it has successfully made the link but, in fact, no link has been created :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants