[11.x] Allow SyncQueue to dispatch jobs after a transaction is committed
#48860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusjatenee
force-pushed
the
bugfix/sync-queue-after-commit-11
branch
from
350bf9b
to
69b661b
Compare
hansnn
added a commit
to hansnn/laravel-framework
that referenced
this pull request
Apr 15, 2024
AfterCommit support was added to the SyncQueue in laravel#48860. However, it only works if the job in question implements the ShouldQueueAfterCommit interface or sets the afterCommit property - it does not work if after_commit is set to true in the sync driver's configuration. This makes the behavior inconsistent, which is what this commit solves by also considering the after_commit config.
taylorotwell
added a commit
that referenced
this pull request
Apr 15, 2024
* Consider after_commit config in SyncQueue AfterCommit support was added to the SyncQueue in #48860. However, it only works if the job in question implements the ShouldQueueAfterCommit interface or sets the afterCommit property - it does not work if after_commit is set to true in the sync driver's configuration. This makes the behavior inconsistent, which is what this commit solves by also considering the after_commit config. * Update SyncQueue.php * Update SyncQueue.php --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing #48705 we discovered that the
syncdriver doesn't support pushing jobs after a transaction commits — that's because it'spushimplementation is different from "real" queue drivers.This PR adds that functionality to sync. I personally don't think it's a big deal because I imagine most people are using real queue drivers, but I think it's good to have them all behave the same.
Although there are no contract changes, I targeted 11.x since it changes existing behavior.