New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import changes from old fork #1127
Conversation
…ap in certain circumstances
… refactored to use Database class)
...and simplified/refactored some other code
...plus some cache invalidation improvements
…suite/lansuite into import-changes-from-old-fork
…e comitted too early
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments
Should be fine to give it another look |
Fixed spelling mistake, added some more description
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thank you!
What is this PR doing?
There are multiple smaller fixes and improvements (and also some larger ones) that I've developed in the past in a fork.
As these are quite outdated I'll fix, refactor, improve as needed.
This is the first batch as foundation to then implement some larger and more interesting ones (as support for GiroCode QR-Code creation)
Which issue(s) this PR fixes:
Fixes #none
Checklist
CHANGELOG.md
entry