Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import changes from old fork #1127

Merged
merged 20 commits into from May 15, 2024
Merged

Conversation

M4LuZ
Copy link
Collaborator

@M4LuZ M4LuZ commented May 4, 2024

What is this PR doing?

There are multiple smaller fixes and improvements (and also some larger ones) that I've developed in the past in a fork.
As these are quite outdated I'll fix, refactor, improve as needed.
This is the first batch as foundation to then implement some larger and more interesting ones (as support for GiroCode QR-Code creation)

Which issue(s) this PR fixes:

Fixes #none

Checklist

  • CHANGELOG.md entry
  • Documentation update

@M4LuZ M4LuZ requested a review from andygrunwald May 4, 2024 12:06
inc/Classes/Func.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@andygrunwald andygrunwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments

@M4LuZ
Copy link
Collaborator Author

M4LuZ commented May 14, 2024

Should be fine to give it another look

Fixed spelling mistake, added some more description
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@andygrunwald andygrunwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Thank you!

@andygrunwald andygrunwald merged commit 1746939 into master May 15, 2024
5 of 6 checks passed
@andygrunwald andygrunwald deleted the import-changes-from-old-fork branch May 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants