Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle misconfigured tools #1054

Merged
merged 6 commits into from May 17, 2024

Conversation

anunnakian
Copy link
Contributor

@anunnakian anunnakian commented May 3, 2024

Issue

#983

Change

When we configure a tool by using a Class instance, we get an exception because only object instances are allowed.

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

Checklist for adding new model integration

  • I have added my new module in the BOM

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
  • I have added my new module in the BOM

Checklist for changing existing embedding store integration

  • I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

@langchain4j langchain4j added the P2 High priority label May 6, 2024
@anunnakian anunnakian marked this pull request as draft May 15, 2024 20:49
langchain4j
langchain4j previously approved these changes May 17, 2024
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anunnakian thank you!

@langchain4j langchain4j marked this pull request as ready for review May 17, 2024 07:30
@langchain4j langchain4j merged commit e60c49d into langchain4j:main May 17, 2024
6 checks passed
@anunnakian anunnakian deleted the handle_misconfiguration branch May 17, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants