Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add take_rows operation to the v2 file reader's python bindings #2331

Merged
merged 1 commit into from
May 15, 2024

Conversation

westonpace
Copy link
Contributor

This also plumbs out basic support for take_rows and is a prerequisite for adding a fragment-level take

@github-actions github-actions bot added the enhancement New feature or request label May 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 28.73563% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 80.59%. Comparing base (b61850b) to head (7930e21).

Files Patch % Lines
rust/lance-file/src/v2/reader.rs 11.11% 47 Missing and 1 partial ⚠️
...ust/lance-encoding/src/encodings/logical/struct.rs 42.85% 11 Missing and 1 partial ⚠️
rust/lance-encoding/src/decoder.rs 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
- Coverage   80.64%   80.59%   -0.05%     
==========================================
  Files         192      192              
  Lines       56684    56741      +57     
  Branches    56684    56741      +57     
==========================================
+ Hits        45712    45731      +19     
- Misses       8405     8448      +43     
+ Partials     2567     2562       -5     
Flag Coverage Δ
unittests 80.59% <28.73%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit 578afdd into lancedb:main May 15, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants