Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: row id index structures #2303

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

wjones127
Copy link
Contributor

@wjones127 wjones127 commented May 6, 2024

Closes: #2308

@github-actions github-actions bot added the enhancement New feature or request label May 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 64.55285% with 218 lines in your changes are missing coverage. Please review.

Project coverage is 80.50%. Comparing base (b63da09) to head (cf0abfa).
Report is 8 commits behind head on main.

Files Patch % Lines
rust/lance-table/src/rowids/encoded_array.rs 49.02% 103 Missing and 2 partials ⚠️
rust/lance-table/src/rowids.rs 76.89% 60 Missing and 1 partial ⚠️
rust/lance-table/src/rowids/serde.rs 64.13% 24 Missing and 28 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2303      +/-   ##
==========================================
- Coverage   80.66%   80.50%   -0.17%     
==========================================
  Files         191      194       +3     
  Lines       56304    57052     +748     
  Branches    56304    57052     +748     
==========================================
+ Hits        45419    45931     +512     
- Misses       8340     8549     +209     
- Partials     2545     2572      +27     
Flag Coverage Δ
unittests 80.50% <64.55%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the row id index data structure
2 participants