Replace using namespace
in headers with explicit namespaces.
#43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one part to resolve issue lancaster-university/codal-microbit-v2#240:
using namespace codal
shouldn't be used in header files codal-microbit-v2#240To avoid namespace pollution headers should not use
using namespace codal;
, and instead it can be added into any.cpp
files that needed (all of them in this repo).I still need to test this PR in isolation with a normal CODAL build, so I'll leave this as a draft PR until I've finished that.