Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor QoL improvements #1584

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Minor QoL improvements #1584

wants to merge 2 commits into from
+49 −2

Conversation

AminArria
Copy link
Contributor

This PR introduces 2 changes that need to be tested in builds which means I can't test them and need help :D

  • Version number, text showing version should be something like 20240313201905-pre-alpha which is roughly year month day hour minute second. We could simplify a bit of the text, so feel free to comment on it. Also, we could expand the space for the text
  • Default server, when building in Unity editor it should default to localhost, but when making builds they should default to Brazil server (was the current setup)

BertovDev
BertovDev requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@BertovDev BertovDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BuildTimestamp not working on mobile Build.

@BertovDev
Copy link
Contributor

Implemented server selection QoL in #1611

@AngieDutra AngieDutra marked this pull request as draft March 21, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BertovDev BertovDev BertovDev requested changes

@jrchatruc jrchatruc Awaiting requested review from jrchatruc jrchatruc is a code owner

@manucamejo manucamejo Awaiting requested review from manucamejo manucamejo is a code owner

@tvillegas98 tvillegas98 Awaiting requested review from tvillegas98 tvillegas98 is a code owner

@fkrause98 fkrause98 Awaiting requested review from fkrause98 fkrause98 is a code owner

@martinacantaro martinacantaro Awaiting requested review from martinacantaro martinacantaro is a code owner

@mgrunwaldt mgrunwaldt Awaiting requested review from mgrunwaldt mgrunwaldt is a code owner

@AngieDutra AngieDutra Awaiting requested review from AngieDutra AngieDutra is a code owner

@ncontinanza ncontinanza Awaiting requested review from ncontinanza ncontinanza is a code owner

@saugon saugon Awaiting requested review from saugon saugon is a code owner

@marco-paulucci marco-paulucci Awaiting requested review from marco-paulucci marco-paulucci is a code owner

@agustinesco agustinesco Awaiting requested review from agustinesco agustinesco is a code owner

@mFragaBA mFragaBA Awaiting requested review from mFragaBA mFragaBA is a code owner

@tkz00 tkz00 Awaiting requested review from tkz00 tkz00 is a code owner

@Nico-Sanchez Nico-Sanchez Awaiting requested review from Nico-Sanchez Nico-Sanchez is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AminArria @BertovDev