Fix bug in receive_one_ping func #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to bump a version here? @laixintao |
|
Don't merge, looks like we have something to fix on OS X this time... |
|
FYI: An article about ping without root by @lilydjwg here: https://blog.lilydjwg.me/2013/10/29/non-privileged-icmp-ping.41390.html |
|
We don't need to bumpversion on branch, only bumpversion on master. |
|
Ping ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
receive_one_pingfunction now and this PR intends to fix itWhen we are using
SOCK_DGRAMto send packets, thepacket_idfrom the reply will be filled by the kernel and it could be different(leading to anall packet lost problem)For packets sent through
SOCK_DGRAM, we don't need to checkpacket_id.#21 (comment)