feat(runtime): add feature support runing in docker env #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2024 09:17
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
HUAHUAI23 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
1 similar comment
|
HUAHUAI23 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
💥 laf nodejs runtime init image built successfully for pr 1930 digest: |
|
💥 laf nodejs runtime image built successfully for pr 1930 digest: |
|
💥 laf server image built successfully for pr 1930 digest: |
added 2 commits
March 30, 2024 04:49
HUAHUAI23
changed the title
added 2 commits
March 30, 2024 05:23
0fatal
requested changes
Apr 2, 2024
|
|
||
| await fs.mkdir(WORKSPACE_PATH, { recursive: true }) | ||
|
|
||
| const funcs = await DatabaseAgent.db |
| await pipeline(readStream, res).then(() => { | ||
| // after pipe the file stream, remove the tar file | ||
| fsPromises.unlink(TAR_FILE_PATH).catch((unlinkError) => { | ||
| console.error('Error removing file:', unlinkError) |
| ) | ||
| } | ||
|
|
||
| // /docker-file |
| res: Response, | ||
| ) { | ||
| try { | ||
| // Save them to the workspace directory |
| try { | ||
| await fs.rm(WORKSPACE_PATH, { recursive: true, force: true }) | ||
| } catch (err) { | ||
| console.error('Error removing the workspace directory:', err) |
| } | ||
|
|
||
| for (const [key, value] of Object.entries(ENV)) { | ||
| if (keysToInclude.includes(key)) { |
| envVariablesString = envVariablesString.replace(/\\\n\s*$/, '') | ||
|
|
||
| // version from env todo | ||
| const DOCKER_FILE = ` |
| export async function handleDockerFile(_: IRequest, res: Response) { | ||
| try { | ||
| const ENV = process.env | ||
| const keysToInclude = [ |
| USER node | ||
| RUN npm install ${ENV.DEPENDENCIES} || true | ||
|
|
||
| RUN curl -o /tmp/cloud_functions.tar https://${ENV.RUNTIME_DOMAIN}/_/${process.env.SERVER_SECRET}/cloud_functions/tar && tar -xf /tmp/cloud_functions.tar -C /app/cloud_functions && rm /tmp/cloud_functions.tar |
There was a problem hiding this comment.
${process.env.SERVER_SECRET} 放在 tar后面，最好用jwt
| USER node | ||
| RUN npm install ${ENV.DEPENDENCIES} || true | ||
|
|
||
| RUN curl -o /tmp/cloud_functions.tar https://${ENV.RUNTIME_DOMAIN}/_/${process.env.SERVER_SECRET}/cloud_functions/tar && tar -xf /tmp/cloud_functions.tar -C /app/cloud_functions && rm /tmp/cloud_functions.tar |
|
这个 pr 先不合， 等一起讨论后再决定 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.