New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(work-in-progress) Classes, user-defined filters, cards can block other cards #108
base: main
Are you sure you want to change the base?
Conversation
Adds and integrates `org-fc-card`, `org-fc-position`, `org-fc-review-session`, and `org-fc-review-session-rating` classes.
Adds `org-fc-review-position-filters` which users can configure to customize the positions that appear in their review. Example use cases: - Limit the number of new positions per review - Only include one position with a specific tag - Only include one position per file
Use a box value of -1 to indicate a new (never been reviewed) position.
Consider three cards: 1. card-A with an ID of `card-a-id` 1. card-B with an ID of `card-b-id` 1. card-C with an ID of `card-c-id` The user can set card-B as blocking card-A and card-C by setting the `FC_BLOCKED_BY` property on cards A and B to `card-b-id`. Alternatively, the user could set card-A and card-B as blocking card-C by setting the `FC_BLOCKED_BY` property on card-C to `card-a-id,card-b-id`.
Thanks for all this work! I'll go over what I think are the main components of this and review each. ClassesI like the idea and implementation of the classes. In case different spacing algorithms (with different parameters to track) are supported at some time, Blocking CardsBecause I can't see how I would use this in my learning workflow, I don't have an opinion on this. Identifying New CardsWhat if instead of adding a new -1 box, we used box 0 only for new cards? Currently when a review fails, the card back to box 0 (with an interval of 0), Here is a nice explanation of the algorithm / scheduling used by Anki: Doing the same in org-fc seems like a very small change that would solve a few problems at once. |
I think I'd like to get started integrating the classes for cards and positions but I'm not sure how to best do so, As these are significant changes, do you want an "Author:" line in the affected files? |
This pull request contains changes addressing:
org-fc-card
,org-fc-position
,org-fc-review-session
, andorg-fc-review-session-rating
I've included everything in one pull request as it's become a hassle to maintain separate pull requests here and a merged branch for my own local config. I'm happy to split it up when the time comes to merge things in. This pull request can serve as a center for review in the meantime.
Regarding #106 (comment): I think my changes to how cards/positions are shuffled should resolve this concern.
TODO:
context
objects