Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add france and update orange pl #254

Merged
merged 5 commits into from May 16, 2024
Merged

Conversation

fillwithjoy1
Copy link
Contributor

@fillwithjoy1 fillwithjoy1 commented Feb 16, 2024

added orange pl to add ims apn. I've just seen too many discussions where wifi calling isn't working unless they added the ims apn.

oh and add compatibility with NRJ mobile carrier (see #175)

close #175

added orange pl to add ims apn. I've just seen too many discussions where wifi calling isn't working unless they added the ims apn.

oh and add compatibility with NRJ mobile carrier (still need to get the numbers, chore)
@fillwithjoy1
Copy link
Contributor Author

okay just wondering, what happens if a carrier has multiple mnc codes?

Copy link
Contributor Author

@fillwithjoy1 fillwithjoy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #136, there are people who report adding IMS APN works (and they are on orange. maybe im stupid because orange seems to exist upon multiple countries. maybe this entire commit is unnecessary...)

| Europe | Various countries | Elisa | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/125#issue-1698533656) |
| Europe | Various countries | Saunalahti | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/125#issue-1698533656) |
| Europe | Switzerland (228) | Salt (03) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/125#issuecomment-1546696568) |
| Europe | Poland (260) | Orange PL (03) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/17) |
| Europe | Poland (260) | Orange PL (03) | O | O | [Reference](https://github.com/kyujin-cho/pixel-volte-patch/issues/17). If Vo-Wifi isn't working, you may need to add the `ims` APN [Reference](https://github.com/kyujin-cho/pixel-volte-patch/discussions/1#discussioncomment-6261820) |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait should I change the link to
#136 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably because that was turkcell.

@kyujin-cho
Copy link
Owner

okay just wondering, what happens if a carrier has multiple mnc codes?

@fillwithjoy1 Just adding every available MNC into single cell will be enough.

@fillwithjoy1
Copy link
Contributor Author

okay just wondering, what happens if a carrier has multiple mnc codes?

@fillwithjoy1 Just adding every available MNC into single cell will be enough.

Okay, I think this pull request is ready to be reviewed now

@fillwithjoy1 fillwithjoy1 deleted the branch kyujin-cho:main February 16, 2024 23:45
@fillwithjoy1 fillwithjoy1 deleted the main branch February 16, 2024 23:45
@fillwithjoy1 fillwithjoy1 restored the main branch February 16, 2024 23:55
@fillwithjoy1 fillwithjoy1 reopened this Feb 16, 2024
@fillwithjoy1 fillwithjoy1 changed the title Close #175 and add note for Orange PL compatibility: add france and update orange Feb 24, 2024
@fillwithjoy1 fillwithjoy1 changed the title compatibility: add france and update orange compatibility: add france and update orange pl Feb 24, 2024
@fillwithjoy1 fillwithjoy1 changed the title compatibility: add france and update orange pl docs: add france and update orange pl Feb 24, 2024
@kyujin-cho kyujin-cho added the documentation Improvements or additions to documentation label May 16, 2024
@kyujin-cho kyujin-cho merged commit 651b0fc into kyujin-cho:main May 16, 2024
5 of 6 checks passed
@fillwithjoy1 fillwithjoy1 deleted the main branch May 16, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Working on Pixel 7 pro with NRJ mobile Carrier
2 participants