Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Collapsable headings #142

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Conversation

rpytel1
Copy link
Contributor

@rpytel1 rpytel1 commented Dec 2, 2020

The current version of nbstripout does not support metadata changes if you use popular adds on: collapsable heading from nbextensions.

Current behaviour

When using collapsable heading extension when a section is closed or open information is saved in Jupyter Notebook.

Desired behaviour

We want to limit all the changes to notebook to useful changes, so information, whether the user is using the extension, is irrelevant.

Fix

As this extension is essentially adding two new fields to the metadata field (either "hidden":True or none and "heading_collapsed:True" or again None) it is only needed to add this fields to ingore line.

Sidenote: Current version from master of repository is not working so for my own purposes I removed last 5 commits to revert to Pypi version.

This PR is adding a new commit on top of master.

@kynan kynan self-requested a review April 5, 2021 15:39
@kynan kynan added this to the 0.4.0 milestone Apr 5, 2021
@kynan
Copy link
Owner

kynan commented Apr 5, 2021

Thanks for your contribution! Another argument for switching to an allowlist #86 :)

@kynan kynan merged commit 74555ac into kynan:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants