Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update delete instances request #2445

Merged
merged 3 commits into from May 13, 2024
Merged

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented May 10, 2024

Description

Extend functionality of DeleteInstance request to delete multiple instances or instances with a certain status. Also, adds auth to it by requiring the system user api key to be provided.

Is this change user facing?

NO

@tedim52 tedim52 requested a review from laurentluce May 10, 2024 14:42
@tedim52 tedim52 enabled auto-merge May 13, 2024 16:07
@tedim52 tedim52 added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit ef9b885 May 13, 2024
52 checks passed
@tedim52 tedim52 deleted the tedi/deleteinstanceupdate branch May 13, 2024 16:30
github-merge-queue bot pushed a commit that referenced this pull request May 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.89.10](0.89.9...0.89.10)
(2024-05-13)


### Features

* update delete instances request
([#2445](#2445))
([ef9b885](ef9b885))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants