feat: add string slice arguments to our parsed_flags library #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry, this isn't fininshed, I'll reopen once set |
omar711
commented
Nov 27, 2023
| cobraFlagSet *flag.FlagSet, | ||
| ) error { | ||
|
|
||
| if defaultValueStr != "" { |
There was a problem hiding this comment.
There's an assumption in the library that defaults will always derive from strings.
We could look to parse string representations of arrays, or add more genral support e.g. for []string here.
However, my thinking is defaults don't make much sense for a slice flag, so just make it clear it won't work, where somebody does specify a default.
auto-merge was automatically disabled
December 15, 2023 15:07
Merge queue setting changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds slice strings to our parsed_flags library. This will let us specify flags for the upcoming static ports work, e.g.:
Is this change user facing?
NO
References (if applicable):