Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table tenis #3290

Closed
wants to merge 2 commits into from
Closed

Table tenis #3290

wants to merge 2 commits into from

Conversation

jayesh2474
Copy link

PR Description πŸ“œ

Summary
In this PR, I addressed the following issues:

1.Implemented a point-based scoring system where the game ends when a player reaches 11 points.
2.Added a function to declare the winner and reset the game.
3.Adjusted ball speed and direction for more accurate and dynamic gameplay.
4.Provided a brief description of the changes made in the code.
PR Description
Fixes #3248

This PR enhances the table tennis game by introducing a point-based scoring system. The game now ends when a player scores 11 points. Additionally, the code has been optimized to improve the accuracy and dynamics of ball movement. A function has been added to declare the winner and reset the game when the winning condition is met.


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) πŸ“Έ



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented May 14, 2024

Thank you @jayesh2474 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

@jayesh2474
Copy link
Author

Game added kindly merge PR

@kunjgit
Copy link
Owner

kunjgit commented May 15, 2024

@jayesh2474 follow proper guidelines and then make your PR again !
would recommend you to go through whole process of contribution !

@kunjgit kunjgit closed this May 15, 2024
@kunjgit
Copy link
Owner

kunjgit commented May 15, 2024

Thank you @jayesh2474 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Table Tennis
2 participants